From f6846ad217e823872e388a5757f3b74b112bdf46 Mon Sep 17 00:00:00 2001
From: Do Siki <dosiki852@gmail.com>
Date: Sun, 23 Aug 2026 11:42:24 +0200
Subject: [PATCH] test(cms): partner-logo test uses unique names and only
 cleans its own files

The previous cleanup emptied proto/public/partners/ entirely, deleting real
committed partner logos during the pre-deploy run. Now the test uploads to
unique run-specific filenames and removes only those.
---
 scripts/test-content-editor-logo.js | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/scripts/test-content-editor-logo.js b/scripts/test-content-editor-logo.js
index b4a3c1e..c4d7b29 100644
--- a/scripts/test-content-editor-logo.js
+++ b/scripts/test-content-editor-logo.js
@@ -134,9 +134,11 @@ async function main() {
 
     // 4. partner logo upload (MITHOME-83)
     const partnerDir = path.join(ROOT, 'proto', 'public', 'partners');
-    const partnerFile = path.join(partnerDir, 'acme.png');
+    // Unique names so the test never collides with real partner logos.
+    const runId = process.pid + '-' + Date.now();
+    const created = [];
     try {
-      const up = await fetch(`${BASE}/partner-logo?name=acme`, {
+      const up = await fetch(`${BASE}/partner-logo?name=acme-${runId}`, {
         method: 'POST',
         headers: { 'Content-Type': 'image/png', 'X-CSRF-Token': csrf, 'Cookie': cookie },
         body: TINY_PNG,
@@ -144,11 +146,12 @@ async function main() {
       assert.equal(up.status, 200);
       const body = await up.json();
       assert.equal(body.ok, true);
-      assert.equal(body.path, '/partners/acme.png');
-      assert.ok(fs.existsSync(partnerFile), 'partner logo file created');
+      assert.equal(body.path, `/partners/acme-${runId}.png`);
+      created.push(path.join(partnerDir, `acme-${runId}.png`));
+      assert.ok(fs.existsSync(created[0]), 'partner logo file created');
 
       // non-PNG → 415
-      const bad = await fetch(`${BASE}/partner-logo?name=x`, {
+      const bad = await fetch(`${BASE}/partner-logo?name=x-${runId}`, {
         method: 'POST',
         headers: { 'Content-Type': 'image/png', 'X-CSRF-Token': csrf, 'Cookie': cookie },
         body: Buffer.from('not a png'),
@@ -156,7 +159,7 @@ async function main() {
       assert.equal(bad.status, 415);
 
       // traversal name is sanitized (no path escape)
-      const trav = await fetch(`${BASE}/partner-logo?name=../evil`, {
+      const trav = await fetch(`${BASE}/partner-logo?name=../evil-${runId}`, {
         method: 'POST',
         headers: { 'Content-Type': 'image/png', 'X-CSRF-Token': csrf, 'Cookie': cookie },
         body: TINY_PNG,
@@ -165,11 +168,10 @@ async function main() {
       const tBody = await trav.json();
       assert.ok(tBody.path.startsWith('/partners/'), 'traversal name is sanitized to a safe slug');
       assert.ok(!tBody.path.includes('..'), 'no traversal in the returned path');
+      created.push(path.join(ROOT, 'proto', 'public', tBody.path));
     } finally {
-      try {
-        for (const f of fs.readdirSync(partnerDir)) fs.unlinkSync(path.join(partnerDir, f));
-        fs.rmdirSync(partnerDir);
-      } catch { /* best effort */ }
+      for (const f of created) { try { fs.unlinkSync(f); } catch { /* noop */ } }
+      try { fs.rmdirSync(partnerDir); } catch { /* only removes when empty */ }
     }
 
     console.log('Content Editor logo upload test: OK');